This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Read the stderr into termination reason when container fails #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=======================================
Coverage 54.98% 54.99%
=======================================
Files 91 91
Lines 4661 4662 +1
=======================================
+ Hits 2563 2564 +1
Misses 1821 1821
Partials 277 277
Continue to review full report at Codecov.
|
wild-endeavor
approved these changes
May 12, 2020
|
No parsing just dropping a better error message |
|
I was thinking if we should use this always? |
|
I think it'll almost always give you a better idea.... I'm thinking we can further limit the size of the message on our side... |
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This change will automatically read the pod log and set it as the termination reason when the container exits with non-zero exit code. In case of flytekit, and it fails to write error.pb, the log will have more information to surface to users.
Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#308