This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Refactor rate limiter for read/write requests #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wild-endeavor
approved these changes
Apr 6, 2020
wild-endeavor
previously approved these changes
Apr 6, 2020
wild-endeavor
previously approved these changes
Apr 6, 2020
wild-endeavor
approved these changes
Apr 6, 2020
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Refactor rate limiter for read/write requests * update config comment * update config comment and external path * remove unused function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This is to split the rate limiter for read and write requests. This PR only includes configuration changes. Actual usage of the rate limiters themselves will reside in the Presto client itself.
Also included the change to use the
GetRawOutputPrefixfrom theOutputWriterfor the location where the external table gets saved so as it's pretty much a one-liner.Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#240