This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Fixing pod plugin event reporting timestamps #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Rammer <[email protected]>
Signed-off-by: Dan Rammer <[email protected]>
Signed-off-by: Dan Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
==========================================
+ Coverage 62.83% 64.06% +1.22%
==========================================
Files 146 146
Lines 12171 9884 -2287
==========================================
- Hits 7648 6332 -1316
+ Misses 3946 2974 -972
- Partials 577 578 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 126 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
2 tasks
eapolinario
previously approved these changes
Mar 9, 2023
8 tasks
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
eapolinario
approved these changes
Mar 23, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* corrected timestamps for pod plugin Signed-off-by: Dan Rammer <[email protected]> * but actually this time Signed-off-by: Dan Rammer <[email protected]> * added reported at support Signed-off-by: Daniel Rammer <[email protected]> * fixed merge Signed-off-by: Daniel Rammer <[email protected]> * updated flyteidl Signed-off-by: Daniel Rammer <[email protected]> * updated flyteidl deps Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Dan Rammer <[email protected]> Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Currently the pod plugin timestamps to detect when a pod started and finished are never hit. This means that when reporting these timestamps, Flyte uses the current time (ie. when Flyte checks the pod status) and consequently these are inaccurate. In this PR we attempt to use the timestamps from the container to ensure accurate reporting.
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
flyteorg/flyte#3272
Follow-up issue
NA