Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Update snowflake endpoints #286

Merged
merged 9 commits into from
Sep 28, 2022
Merged

Update snowflake endpoints #286

merged 9 commits into from
Sep 28, 2022

Conversation

pingsutw
Copy link
Member

TL;DR

Snowflake has updated their API endpoint to api/v2/statements, so we should update the endpoint in the snowflake plugin.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

NA

Follow-up issue

NA

@eapolinario
Copy link
Contributor

Just for reference, I found this KBA about the removal of the old endpoints: https://community.snowflake.com/s/article/snowflake-sql-api-removal-of-the-older-endpoints.

Signed-off-by: Kevin Su <[email protected]>
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #286 (ac8ed89) into master (1637021) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #286   +/-   ##
=======================================
  Coverage   63.32%   63.32%           
=======================================
  Files         145      145           
  Lines        9311     9311           
=======================================
  Hits         5896     5896           
  Misses       2872     2872           
  Partials      543      543           
Flag Coverage Δ
unittests 62.74% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/tasks/plugins/webapi/snowflake/plugin.go 67.08% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pingsutw pingsutw merged commit eed7326 into master Sep 28, 2022
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
* Update snowflake endpoint

Signed-off-by: Kevin Su <[email protected]>

* update endpoint

Signed-off-by: Kevin Su <[email protected]>

* update endpoint

Signed-off-by: Kevin Su <[email protected]>

* update endpoint

Signed-off-by: Kevin Su <[email protected]>

* update endpoint

Signed-off-by: Kevin Su <[email protected]>

* update endpoint

Signed-off-by: Kevin Su <[email protected]>

* update tests

Signed-off-by: Kevin Su <[email protected]>

* fix tests

Signed-off-by: Kevin Su <[email protected]>

Signed-off-by: Kevin Su <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants