Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Ray Cluster Plugin #277

Closed
wants to merge 8 commits into from
Closed

Ray Cluster Plugin #277

wants to merge 8 commits into from

Conversation

pingsutw
Copy link
Member

TL;DR

  • Add ray plugin to create RayCluster custom resource
  • Upgrade the kubeflow operator since the version of sigs.k8s.io/controller-runtime in Kuberay is incompatible with the one in tf-operator/pytorch-operator
  • Add a new phase PhaseClusterRunning.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#2641

Follow-up issue

NA

pingsutw added 6 commits July 7, 2022 03:16
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw marked this pull request as draft July 19, 2022 14:53
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #277 (782e2a1) into master (902b902) will increase coverage by 0.33%.
The diff coverage is 77.30%.

❗ Current head 782e2a1 differs from pull request most recent head d5bd00f. Consider uploading reports for the commit d5bd00f to get more accurate results

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   62.97%   63.31%   +0.33%     
==========================================
  Files         142      143       +1     
  Lines        8970     9194     +224     
==========================================
+ Hits         5649     5821     +172     
- Misses       2799     2845      +46     
- Partials      522      528       +6     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/tasks/pluginmachinery/core/phase.go 23.45% <0.00%> (-0.60%) ⬇️
go/tasks/pluginmachinery/core/phase_enumer.go 13.33% <ø> (ø)
go/tasks/plugins/k8s/kfoperators/mpi/mpi.go 74.44% <73.33%> (ø)
...o/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go 71.62% <73.33%> (-0.38%) ⬇️
go/tasks/plugins/cluster_resource/ray/ray.go 77.67% <77.67%> (ø)
...s/plugins/k8s/kfoperators/tensorflow/tensorflow.go 75.86% <77.77%> (-0.28%) ⬇️
...machinery/flytek8s/config/k8spluginconfig_flags.go 50.00% <100.00%> (ø)
.../plugins/k8s/kfoperators/common/common_operator.go 79.38% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 902b902...d5bd00f. Read the comment docs.

@pingsutw pingsutw force-pushed the ray branch 5 times, most recently from c122723 to c448118 Compare July 20, 2022 09:21
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw changed the title Ray Plugin Ray Cluster Plugin Jul 21, 2022
@pingsutw pingsutw closed this Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant