This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Support BQ plugin to write structured dataset as output #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 62.29% 62.41% +0.11%
==========================================
Files 141 142 +1
Lines 8811 8831 +20
==========================================
+ Hits 5489 5512 +23
+ Misses 2823 2819 -4
- Partials 499 500 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
10 tasks
| @@ -273,13 +280,54 @@ func (p Plugin) Status(_ context.Context, tCtx webapi.StatusContext) (phase core | |||
| resource.Status.ErrorResult.Message, | |||
| taskInfo), nil | |||
| } | |||
|
|
|||
| err = writeOutput(ctx, tCtx, resource.OutputLocation) | |||
There was a problem hiding this comment.
i'm confused, were we not writing an output before?
There was a problem hiding this comment.
We didn't write any output before.
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* BQ output structured dataset Signed-off-by: Kevin Su <[email protected]> * Fixed test Signed-off-by: Kevin Su <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Su [email protected]
TL;DR
support BQ plugin to write structured dataset as output
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Related to flyteorg/flytekit#789
Follow-up issue
NA