This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Added mpi backend plugin #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
==========================================
+ Coverage 61.46% 62.08% +0.62%
==========================================
Files 140 141 +1
Lines 8620 8736 +116
==========================================
+ Hits 5298 5424 +126
+ Misses 2837 2813 -24
- Partials 485 499 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Yuvraj <[email protected]>
kumare3
reviewed
Aug 13, 2021
yindia
commented
Aug 18, 2021
Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
8 tasks
yindia
force-pushed
the
feature/mpi
branch
3 times, most recently
from
7492373 to
45cea17
Compare
Signed-off-by: Yuvraj <[email protected]>
8 tasks
Signed-off-by: Yuvraj <[email protected]>
katrogan
reviewed
Sep 30, 2021
Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
katrogan
reviewed
Oct 14, 2021
katrogan
reviewed
Oct 14, 2021
Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
|
@evalsocket lets improve the description for this PR. This is an important PR |
kumare3
reviewed
Oct 18, 2021
kumare3
reviewed
Oct 18, 2021
kumare3
reviewed
Oct 18, 2021
| taskPhaseInfo pluginsCore.TaskInfo) (pluginsCore.PhaseInfo, error) { | ||
| switch currentCondition.Type { | ||
| case commonKf.JobCreated: | ||
| return pluginsCore.PhaseInfoQueued(occurredAt, pluginsCore.DefaultPhaseVersion, "JobCreated"), nil |
There was a problem hiding this comment.
Instead of JobCreated can we add a better message as this can be seen in the UI. For example
`New job name: %s submitted to KF Training operator
There was a problem hiding this comment.
I don't have a job name here that's why added a comment without name
kumare3
reviewed
Oct 18, 2021
kumare3
reviewed
Oct 18, 2021
|
I have a few comments then we can merge |
Signed-off-by: Yuvraj <[email protected]>
kumare3
approved these changes
Oct 18, 2021
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Added mpi plugin Signed-off-by: Yuvraj <[email protected]> * Remove launcher log Signed-off-by: Yuvraj <[email protected]> * More changes Signed-off-by: Yuvraj <[email protected]> * Fix test and lint Signed-off-by: Yuvraj <[email protected]> * fix gomod issue Signed-off-by: Yuvraj <[email protected]> * More changes Signed-off-by: Yuvraj <[email protected]> * make lint Signed-off-by: Yuvraj <[email protected]> * Fix unit test Signed-off-by: Yuvraj <[email protected]> * Added more unit test Signed-off-by: Yuvraj <[email protected]> * Fix unit test Signed-off-by: Yuvraj <[email protected]> * Added documentation Signed-off-by: Yuvraj <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Implements native k8s backend plugin for Kubeflow MPI operator.
Type
Are all requirements met?
Complete description
MPI plugin implemented using kubeflow mpi operator . Flyte will create the MPI job and mpi operator will take care of execution.
MPI plugin implemented using latest MPI CRD i.e
v2beta1. The user should havev2beta1CRD installed in cluster.Future plan is to replace MPI operator with a training operator.
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes flyteorg/flyte#1543
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/