This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Handle pod task: version 2 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katrina Rogan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
==========================================
+ Coverage 61.48% 61.55% +0.06%
==========================================
Files 132 132
Lines 7260 7291 +31
==========================================
+ Hits 4464 4488 +24
- Misses 2367 2371 +4
- Partials 429 432 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Katrina Rogan <[email protected]>
kumare3
reviewed
May 27, 2021
| } | ||
| } else { | ||
| } else if task.TaskTypeVersion == 1 { |
There was a problem hiding this comment.
should we split the version handling into functions? this will get very confusing otherwise?
There was a problem hiding this comment.
and lets add when is the version active until?
kumare3
previously approved these changes
May 27, 2021
Signed-off-by: Katrina Rogan <[email protected]>
kumare3
approved these changes
May 27, 2021
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Katrina Rogan [email protected]
TL;DR
This allows for richer customization of PodSpecs for Pod tasks
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#1050
Follow-up issue
NA