This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Demystify with additional conditions #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In the case when a configmap/secret is not found, the pod stays in pending Signed-off-by: Ketan Umare <[email protected]>
EngHabu
approved these changes
Mar 16, 2021
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
+ Coverage 60.33% 60.40% +0.07%
==========================================
Files 130 130
Lines 7027 7027
==========================================
+ Hits 4240 4245 +5
+ Misses 2362 2357 -5
Partials 425 425
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
milton0825
pushed a commit
to milton0825/flyteplugins
that referenced
this pull request
May 25, 2021
- In the case when a configmap/secret is not found, the pod stays in pending Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Chao-Han Tsai <[email protected]>
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
- In the case when a configmap/secret is not found, the pod stays in pending Signed-off-by: Ketan Umare <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ketan Umare [email protected]
TL;DR
In the case when a configmap/secret is not found, the pod stays in pending. this PR ensures that such a pod fails
Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#800