Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add support for custom KubeClient #154

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Add support for custom KubeClient #154

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca00149
Add support for custom KubeClient
regadas Mar 9, 2021
a0eaa51
review
regadas Mar 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions go/tasks/pluginmachinery/k8s/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@ type PluginEntry struct {
// support the same task type. This must be a subset of RegisteredTaskTypes and at most one default per task type
// is supported.
DefaultForTaskTypes []pluginsCore.TaskType
// Returns a new KubeClient to be used instead of the internal controller-runtime client.
NewKubeClient func(ctx context.Context) (pluginsCore.KubeClient, error)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we call this - customKubeClient

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed

// Boolean that indicates if kubernetes resources that this plugin is responsible for should include OwnerReferences.
// Ingoring is only useful if resources will be created in a remote cluster.
OverrideInjectOwnerReferences *bool
// Boolean flag that indicates if a finalizer should be injected.
// This will override the `inject-finalizer` set under k8s config.
OverrideInjectFinalizer *bool
}

// Special context passed in to plugins when checking task phase
Expand Down