This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Mark items from workqueue as Done() #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumare3
reviewed
Nov 9, 2020
|
|
||
| // Mark the item as done processing. The logic below will determine whether it should go back into the queue | ||
| // (behind everything else) or whether it requires no further processing. | ||
| q.queue.Done(item) |
There was a problem hiding this comment.
uh ho! This will case a lot of chaos?
|
Lets get some unit tests going for this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Item processor queue used to process catalog items and outputs coalescing for arrays has a bug where it doesn't mark items as done when it finishes processing. This leads to the items being processed again and again wasting resources, clogging the queue and flooding external services with unnecessary requests.
Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#587