This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Update Spark Plugin to v1beta2 #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 27, 2020 00:28
akhurana001
changed the title
kumare3
reviewed
Oct 29, 2020
| @@ -17,7 +17,7 @@ import ( | |||
| "github.com/lyft/flyteplugins/go/tasks/pluginmachinery/utils" | |||
| "k8s.io/client-go/kubernetes/scheme" | |||
|
|
|||
| sparkOp "github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/apis/sparkoperator.k8s.io/v1beta1" | |||
| sparkOp "github.com/GoogleCloudPlatform/spark-on-k8s-operator/pkg/apis/sparkoperator.k8s.io/v1beta2" | |||
There was a problem hiding this comment.
thats it no changes in the API?
There was a problem hiding this comment.
There are some change like types of some fields in the Spec has changed but we don't use that in flyteplugins i.e. only set those config via spark_conf. The one other change is see is that status is now a sub-resource and the operator needs additional perms for the same.
|
When you do this, can you also change the oss flyte deployment to deploy the new version? |
kumare3
approved these changes
Oct 29, 2020
Will do in flyteorg/flyte#573 once I create a new propeller release . |
akhurana001
changed the title
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* spark v1beta2 * update spark-operator * update spark-operator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move spark plugin to v1beta2 multi-version of Operator. Ref: flyteorg/flyte#573