Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Raw output prefix #115

Merged
merged 3 commits into from
Aug 26, 2020
Merged

Raw output prefix #115

merged 3 commits into from
Aug 26, 2020

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Aug 26, 2020

TL;DR

This will pipe through the raw output data prefix, as set by the flytekit PR, through admin/propeller/propeller's node execution context, to container based plugins that call the replaceTemplateArgs.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

  • Add regex, use regex to fill in the container args.
  • Also accidentally ran make generate so some stuff got updated.

Tracking Issue

flyteorg/flyte#211

Follow-up issue

NA

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2020

Codecov Report

Merging #115 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   58.70%   58.72%   +0.01%     
==========================================
  Files          99       99              
  Lines        5936     5938       +2     
==========================================
+ Hits         3485     3487       +2     
  Misses       2103     2103              
  Partials      348      348              
Impacted Files Coverage Δ
go/tasks/pluginmachinery/utils/template.go 71.60% <100.00%> (+0.35%) ⬆️
...tasks/plugins/k8s/sagemaker/config/config_flags.go 30.00% <100.00%> (+3.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc4e8b5...ec6f5b5. Read the comment docs.

@kumare3 kumare3 self-requested a review August 26, 2020 16:31
Copy link
Contributor

@kumare3 kumare3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wild-endeavor wild-endeavor merged commit 3ebab24 into master Aug 26, 2020
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants