Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataclass transformer test #739

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Fix dataclass transformer test #739

merged 2 commits into from
Nov 5, 2021

Conversation

eapolinario
Copy link
Collaborator

TL;DR

test_dataclass_transformer is broken after bumping marshmallow-jsonchema to 0.13.0

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

fuhrysteve/marshmallow-jsonschema#152 changed the type of the python int to integer, as opposed to number.

Tracking Issue

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #739 (73c79cb) into master (17201ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #739   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files         341      341           
  Lines       28915    28915           
  Branches     2381     2381           
=======================================
  Hits        24755    24755           
  Misses       3527     3527           
  Partials      633      633           
Impacted Files Coverage Δ
tests/flytekit/unit/core/test_type_engine.py 99.71% <ø> (ø)
flytekit/core/type_engine.py 88.47% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17201ce...73c79cb. Read the comment docs.

@eapolinario eapolinario mentioned this pull request Nov 5, 2021
8 tasks
Copy link
Contributor

@wild-endeavor wild-endeavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but what does this mean?

@eapolinario
Copy link
Collaborator Author

Yee and I talked offline about this and the conclusion is that this new version of marshmallow-jsonschema is not a breaking change, so we're going to go forward with this PR.

@eapolinario eapolinario merged commit d7c382f into master Nov 5, 2021
reverson pushed a commit to reverson/flytekit that referenced this pull request May 27, 2022
* Regenerate requirements

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix dataclass transformer test

Signed-off-by: Eduardo Apolinario <[email protected]>

Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants