Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[BUG] Flytekit model file organization improvement (#706)" #735

Merged
merged 4 commits into from
Nov 2, 2021

Conversation

wild-endeavor
Copy link
Contributor

This reverts commit b0da779.

Signed-off-by: Yee Hing Tong [email protected]

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/lyft/flyte/issues/

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

Signed-off-by: Yee Hing Tong <[email protected]>
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #735 (0e25f8d) into master (751425d) will decrease coverage by 0.04%.
The diff coverage is 94.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
- Coverage   85.79%   85.74%   -0.05%     
==========================================
  Files         362      362              
  Lines       30010    29996      -14     
  Branches     2444     2444              
==========================================
- Hits        25746    25721      -25     
- Misses       3621     3632      +11     
  Partials      643      643              
Impacted Files Coverage Δ
flytekit/common/component_nodes.py 82.66% <ø> (ø)
flytekit/common/mixins/launchable.py 70.58% <ø> (ø)
flytekit/engines/common.py 79.60% <ø> (ø)
flytekit/models/array_job.py 91.66% <ø> (ø)
flytekit/models/core/types.py 100.00% <ø> (+1.29%) ⬆️
flytekit/models/matchable_resource.py 75.91% <ø> (ø)
flytekit/models/node_execution.py 89.61% <ø> (ø)
flytekit/models/presto.py 80.00% <ø> (ø)
flytekit/models/project.py 100.00% <ø> (ø)
flytekit/models/qubole.py 96.36% <ø> (ø)
... and 150 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 751425d...0e25f8d. Read the comment docs.

Copy link
Collaborator

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we go again!

Jokes aside, the path forward for this is awesome.

@wild-endeavor wild-endeavor merged commit 673e076 into master Nov 2, 2021
reverson pushed a commit to reverson/flytekit that referenced this pull request May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants