Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joblib integration tests #677

Merged
merged 4 commits into from
Sep 29, 2021
Merged

Joblib integration tests #677

merged 4 commits into from
Sep 29, 2021

Conversation

cosmicBboy
Copy link
Contributor

TL;DR

Add more unit/integration tests for FlyteFile.

Type

  • Bug Fix
  • Feature
  • Plugin
  • Tests

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

This PR adds unit tests for the different FlyteFile type variants, as well as an integration test to make sure that the JoblibSerialized type can be correctly serialized/deserialized when used in a FlyteRemote.

Tracking Issue

NA

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #677 (5dc66ca) into master (f6ee06f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage   85.63%   85.65%   +0.01%     
==========================================
  Files         355      355              
  Lines       29650    29661      +11     
  Branches     2415     2415              
==========================================
+ Hits        25391    25406      +15     
+ Misses       3618     3615       -3     
+ Partials      641      640       -1     
Impacted Files Coverage Δ
tests/flytekit/integration/remote/test_remote.py 91.62% <100.00%> (+0.51%) ⬆️
flytekit/types/file/file.py 90.84% <0.00%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6ee06f...5dc66ca. Read the comment docs.

Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
@cosmicBboy cosmicBboy merged commit 6da3f16 into master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants