Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add more unit/integration tests for
FlyteFile
.Type
Are all requirements met?
Code documentation addedAny pending items have an associated IssueComplete description
This PR adds unit tests for the different
FlyteFile
type variants, as well as an integration test to make sure that theJoblibSerialized
type can be correctly serialized/deserialized when used in aFlyteRemote
.Tracking Issue
NA
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/