-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for python pickle type in flytekit/flyte #667
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
bc8b607
Init python pickle
pingsutw 5c596ba
Refactor pickle support
pingsutw 97c1ff1
Fixed lint
pingsutw 5cbff83
Fixed lint
pingsutw 5f7094e
Fixed register error
pingsutw 0cdb183
Added tests
pingsutw 46a7180
Fixed lint
pingsutw 12abcb8
Handle list of pickle
pingsutw 97b25bd
Fixed lint
pingsutw 395220c
Added assert_type
pingsutw ff2083f
Updated comment
pingsutw 7bdeaba
Remove unnecessary cast
pingsutw d3907f0
Added more tests
pingsutw 5865e4e
Fixed test
pingsutw 7f0b513
Address comment
pingsutw e6c04c6
Update list of pickle
pingsutw 3ce284b
Update list of pickle
pingsutw 0f4fad2
Update list of pickle
pingsutw 3fc3943
Fix tests
pingsutw 8e4b3cf
Fix tests
pingsutw 249ff13
Fix tests
pingsutw 842425f
Fix tests
pingsutw e22cc93
Fixed test
pingsutw 59f6b70
Fixed test
pingsutw 1dd1fd4
Fixed test
pingsutw c25aafe
add test
wild-endeavor d3de4c0
add test
wild-endeavor 5ab1328
Fixed lint
pingsutw d2c984d
Fixed import
pingsutw a3daf49
Handle nested list and dict
pingsutw 55eea32
Added tests
pingsutw 70158c7
Fixed lint
pingsutw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixed test
Signed-off-by: Kevin Su <pingsutw@apache.org>
- Loading branch information
commit 1dd1fd40537e984c1433c8e89bf417cab1641f45
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will not cancel all in-progress jobs if any unit test failed.
For example, Sometimes the test only failed with Python 3.9, but it will cancel the other tests with Python 3.7 or 3.8. It will be easy to debug If I know the test fail with which python version.