Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests - pull in latest flytekit #641

Merged
merged 5 commits into from
Sep 9, 2021
Merged

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Sep 7, 2021

Signed-off-by: Yee Hing Tong [email protected]

TL;DR

The mock repo wasn't getting updated.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

make requirements in the mock workflows repo.

Follow-up issue

This should really point to the code in the flytekit PR itself, rather than any released version of flytekit. Overhauling this will tie into
flyteorg/flyte#1364 possibly.

Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
katrogan
katrogan previously approved these changes Sep 7, 2021
Signed-off-by: Yee Hing Tong <[email protected]>
@pingsutw
Copy link
Member

pingsutw commented Sep 7, 2021

We can pin pip, setuptools, wheel version to fix Install dependencies error.
python -m pip install pip==21.2.4 setuptools==57.4.0 wheel==0.37.0
pingsutw@1568ff4

@pingsutw
Copy link
Member

pingsutw commented Sep 7, 2021

I still got an error. remote client failed to connect to Flyte server in integration tests. https://github.com/pingsutw/flytekit/runs/3537067057?check_suite_focus=true

Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #641 (011f07d) into master (44c74b9) will increase coverage by 0.00%.
The diff coverage is 94.23%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #641   +/-   ##
=======================================
  Coverage   85.85%   85.86%           
=======================================
  Files         397      397           
  Lines       31150    31193   +43     
  Branches     2502     2507    +5     
=======================================
+ Hits        26743    26783   +40     
- Misses       3732     3735    +3     
  Partials      675      675           
Impacted Files Coverage Δ
tests/flytekit/unit/cli/pyflyte/test_package.py 92.94% <87.50%> (-2.15%) ⬇️
flytekit/clis/sdk_in_container/serialize.py 49.04% <100.00%> (+3.36%) ⬆️
flytekit/core/local_cache.py 78.57% <100.00%> (ø)
flytekit/models/interface.py 98.75% <100.00%> (ø)
...sts/flytekit/unit/common_tests/test_launch_plan.py 100.00% <100.00%> (ø)
tests/flytekit/unit/common_tests/test_workflow.py 96.32% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28153cc...011f07d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants