-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integration tests - pull in latest flytekit #641
Conversation
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
We can pin |
I still got an error. remote client failed to connect to Flyte server in integration tests. https://github.com/pingsutw/flytekit/runs/3537067057?check_suite_focus=true |
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #641 +/- ##
=======================================
Coverage 85.85% 85.86%
=======================================
Files 397 397
Lines 31150 31193 +43
Branches 2502 2507 +5
=======================================
+ Hits 26743 26783 +40
- Misses 3732 3735 +3
Partials 675 675
Continue to review full report at Codecov.
|
Signed-off-by: Yee Hing Tong [email protected]
TL;DR
The mock repo wasn't getting updated.
Type
Are all requirements met?
Complete description
make requirements
in the mock workflows repo.Follow-up issue
This should really point to the code in the flytekit PR itself, rather than any released version of flytekit. Overhauling this will tie into
flyteorg/flyte#1364 possibly.