Adopt flyteidl's ordered variable map change #608
Conversation
Signed-off-by: Sean Lin <[email protected]>
Signed-off-by: Sean Lin <[email protected]>
Signed-off-by: Sean Lin <[email protected]>
flytekit/models/interface.py
Outdated
| return _interface_pb2.VariableMap(variables={k: v.to_flyte_idl() for k, v in _six.iteritems(self.variables)}) | ||
| return _interface_pb2.VariableMap( | ||
| variables=[ | ||
| _interface_pb2.VariableMapEntry(name=k, var=v.to_flyte_idl()) for k, v in _six.iteritems(self.variables) |
There was a problem hiding this comment.
while we're at it, let's delete six from this file.
There was a problem hiding this comment.
there's a couple failed tests too i think... and by a couple i mean 18,238 :)
It worked on my machine...
I did pip install -e for the flyteidl dependency. I'll update the version once the flyteidl change is released.
There was a problem hiding this comment.
while we're at it, let's delete
sixfrom this file.
And drop Python 2 compatibility?
There was a problem hiding this comment.
we haven't had python 2 compatibility in forever... it's just too much work to delete six all at once so i generally just do it when i'm working in the file.
I did pip install -e for the flyteidl dependency. I'll update the version once the flyteidl change is released. Let me know if there's a better way to do this. |
* remove six * change parameter field name Signed-off-by: Sean Lin <[email protected]>
Signed-off-by: Sean Lin <[email protected]>
Signed-off-by: Sean Lin <[email protected]>
Signed-off-by: Sean Lin <[email protected]>
…le-map # Conflicts: # setup.py
Signed-off-by: Sean Lin <[email protected]>
…le-map # Conflicts: # dev-requirements.txt
Signed-off-by: Sean Lin <[email protected]>
Signed-off-by: Sean Lin <[email protected]>
mayitbeegh
changed the title
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
==========================================
+ Coverage 85.85% 85.86% +0.01%
==========================================
Files 397 397
Lines 31150 31112 -38
Branches 2502 2495 -7
==========================================
- Hits 26743 26714 -29
+ Misses 3732 3723 -9
Partials 675 675
Continue to review full report at Codecov.
|
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
This reverts commit 677bdb9. Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
This reverts commit 11a2998. Signed-off-by: Eduardo Apolinario <[email protected]>
This reverts commit 204b13f Signed-off-by: Sean Lin [email protected]
This reverts commit 204b13f Signed-off-by: Sean Lin <[email protected]>
This reverts commit 204b13f Upgrade flyteidl Signed-off-by: Sean Lin <[email protected]>
This reverts commit 204b13f Upgrade flyteidl Signed-off-by: Sean Lin <[email protected]>
* Revert "Adopt flyteidl's ordered variable map change (#608)" This reverts commit 204b13f * Upgrade flyteidl to 0.21.0 Signed-off-by: Sean Lin <[email protected]>
Signed-off-by: Sean Lin [email protected]
TL;DR
See flyteorg/flyteidl#206
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/