Raw output prefix takes precedence for remote proxy creation in entrypoint #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wild-endeavor
changed the title
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
=======================================
Coverage 85.47% 85.47%
=======================================
Files 376 376
Lines 29265 29265
Branches 2350 2350
=======================================
Hits 25014 25014
Misses 3616 3616
Partials 635 635 Continue to review full report at Codecov.
|
Signed-off-by: wild-endeavor <[email protected]>
Signed-off-by: wild-endeavor <[email protected]>
Signed-off-by: wild-endeavor <[email protected]>
Signed-off-by: wild-endeavor <[email protected]>
Signed-off-by: wild-endeavor <[email protected]>
wild-endeavor
force-pushed
the
config-cloud-provider
branch
from
fc970fa to
96431e3
Compare
kumare3
reviewed
Jul 30, 2021
cosmicBboy
approved these changes
Jul 30, 2021
Closed
kumare3
pushed a commit
that referenced
this pull request
Jul 31, 2021
…point (#572) Signed-off-by: wild-endeavor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
When running in GCP without a config file present, flytekit uses the wrong setting to try to determine what environment it's running in. We should base the decision on the offloaded data location, not the cloud provider setting, which defaults to AWS.
Type
Are all requirements met?
Complete description
Add an extra conditional to first check the
raw_output_data_prefix. Not too worried about the increased complexity becase this section of the code will soon be removed by #559, which should be going in within a week and change.