Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local dynamic execution was missing #569

Merged
merged 3 commits into from
Jul 29, 2021
Merged

Local dynamic execution was missing #569

merged 3 commits into from
Jul 29, 2021

Conversation

wild-endeavor
Copy link
Contributor

TL;DR

Found out local execution of dynamic tasks was missing when investigating something

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Add a case for execution mode LOCAL_TASK_EXECUTION

Tracking Issue

Found when debugging https://flyte-org.slack.com/archives/CREL4QVAQ/p1627384320463800

Signed-off-by: wild-endeavor <[email protected]>
Signed-off-by: wild-endeavor <[email protected]>
Signed-off-by: wild-endeavor <[email protected]>
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #569 (60781b1) into master (ccaac7d) will increase coverage by 0.01%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
+ Coverage   85.45%   85.47%   +0.01%     
==========================================
  Files         376      376              
  Lines       29225    29265      +40     
  Branches     2347     2350       +3     
==========================================
+ Hits        24975    25014      +39     
- Misses       3615     3616       +1     
  Partials      635      635              
Impacted Files Coverage Δ
flytekit/core/python_function_task.py 87.50% <33.33%> (-0.62%) ⬇️
tests/flytekit/unit/core/test_dynamic.py 96.96% <100.00%> (+3.42%) ⬆️
flytekit/core/context_manager.py 93.54% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccaac7d...60781b1. Read the comment docs.

@wild-endeavor wild-endeavor merged commit 716ccc7 into master Jul 29, 2021
kumare3 pushed a commit that referenced this pull request Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants