document flytekit remote module #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cosmicBboy <[email protected]>
cosmicBboy
requested review from
honnix,
katrogan,
kumare3 and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
==========================================
- Coverage 85.46% 85.45% -0.02%
==========================================
Files 376 376
Lines 29158 29225 +67
Branches 2338 2347 +9
==========================================
+ Hits 24921 24975 +54
- Misses 3606 3615 +9
- Partials 631 635 +4
Continue to review full report at Codecov.
|
katrogan
previously approved these changes
Jul 23, 2021
- add debug logging info for project/domain override - update docs Signed-off-by: cosmicBboy <[email protected]>
katrogan
previously approved these changes
Jul 26, 2021
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
katrogan
approved these changes
Jul 26, 2021
no worries! |
kumare3
pushed a commit
that referenced
this pull request
Jul 31, 2021
* document flytekit remote module Signed-off-by: cosmicBboy <[email protected]> * execute method supports project/domain override - add debug logging info for project/domain override - update docs Signed-off-by: cosmicBboy <[email protected]> * update doc-requirements.txt Signed-off-by: cosmicBboy <[email protected]> * address nits Signed-off-by: cosmicBboy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cosmicBboy [email protected]
TL;DR
remotemoduleFlyteRemote.from_environmenttofrom_config@propertyvars for FlyteRemote propertiesType
Are all requirements met?
Tracking Issue
NA
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/