-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement FlyteRemote MVP #547
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmicBboy
requested review from
honnix,
katrogan,
kumare3 and
wild-endeavor
as code owners
July 9, 2021 21:34
katrogan
reviewed
Jul 9, 2021
katrogan
reviewed
Jul 9, 2021
katrogan
reviewed
Jul 9, 2021
cosmicBboy
force-pushed
the
flytekit-remote
branch
from
July 21, 2021 21:47
59aa29c
to
54cb665
Compare
* stop Signed-off-by: Yee Hing Tong <[email protected]> * patches and cleanup Signed-off-by: Yee Hing Tong <[email protected]> * add shell Signed-off-by: Yee Hing Tong <[email protected]> * complete and utter mess Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
cosmicBboy
force-pushed
the
flytekit-remote
branch
from
July 21, 2021 22:07
54cb665
to
a914029
Compare
Signed-off-by: cosmicBboy <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
==========================================
- Coverage 85.47% 85.44% -0.03%
==========================================
Files 372 374 +2
Lines 28995 29040 +45
Branches 2318 2332 +14
==========================================
+ Hits 24783 24813 +30
- Misses 3569 3597 +28
+ Partials 643 630 -13
Continue to review full report at Codecov.
|
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
wild-endeavor
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cosmicBboy [email protected]
TL;DR
Implement FlyteRemote beta
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/