Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement FlyteRemote MVP #547

Merged
merged 16 commits into from
Jul 22, 2021
Merged

implement FlyteRemote MVP #547

merged 16 commits into from
Jul 22, 2021

Conversation

cosmicBboy
Copy link
Contributor

Signed-off-by: cosmicBboy [email protected]

TL;DR

Implement FlyteRemote beta

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/lyft/flyte/issues/

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

flytekit/remote/remote.py Outdated Show resolved Hide resolved
flytekit/remote/remote.py Outdated Show resolved Hide resolved
flytekit/remote/remote.py Outdated Show resolved Hide resolved
wild-endeavor and others added 4 commits July 21, 2021 17:49
* stop

Signed-off-by: Yee Hing Tong <[email protected]>

* patches and cleanup

Signed-off-by: Yee Hing Tong <[email protected]>

* add shell

Signed-off-by: Yee Hing Tong <[email protected]>

* complete and utter mess

Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
@cosmicBboy cosmicBboy changed the title [WIP] implement FlyteRemote implement FlyteRemote MVP Jul 21, 2021
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #547 (74336c5) into master (51373f6) will decrease coverage by 0.02%.
The diff coverage is 77.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
- Coverage   85.47%   85.44%   -0.03%     
==========================================
  Files         372      374       +2     
  Lines       28995    29040      +45     
  Branches     2318     2332      +14     
==========================================
+ Hits        24783    24813      +30     
- Misses       3569     3597      +28     
+ Partials      643      630      -13     
Impacted Files Coverage Δ
flytekit/remote/nodes.py 69.04% <ø> (-5.51%) ⬇️
flytekit/remote/tasks/executions.py 68.18% <ø> (+1.51%) ⬆️
flytekit/remote/workflow_execution.py 72.72% <ø> (-3.01%) ⬇️
flytekit/remote/remote.py 73.50% <68.97%> (-11.62%) ⬇️
tests/flytekit/integration/remote/test_remote.py 87.50% <95.31%> (+6.18%) ⬆️
flytekit/clis/helpers.py 89.88% <100.00%> (ø)
flytekit/loggers.py 88.23% <100.00%> (+0.73%) ⬆️
flytekit/models/launch_plan.py 89.62% <100.00%> (ø)
flytekit/remote/__init__.py 100.00% <100.00%> (ø)
flytekit/remote/component_nodes.py 69.84% <100.00%> (+0.48%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51373f6...74336c5. Read the comment docs.

Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
@cosmicBboy cosmicBboy merged commit 5a39ab2 into master Jul 22, 2021
@cosmicBboy cosmicBboy deleted the flytekit-remote branch July 23, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants