Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make transform_signature_to_interface compatible with 3.9 NamedTuple #534

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

fediazgon
Copy link
Contributor

@fediazgon fediazgon commented Jul 1, 2021

TL;DR

Make transform_signature_to_interface compatible with 3.9 NamedTuple

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Similar to https://github.com/flyteorg/flytekit/pull/471/files

Tracking Issue

flyteorg/flyte#1166

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #534 (21190b6) into master (2c9fab4) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   85.40%   85.40%           
=======================================
  Files         371      371           
  Lines       28473    28476    +3     
  Branches     2304     2305    +1     
=======================================
+ Hits        24318    24321    +3     
  Misses       3523     3523           
  Partials      632      632           
Impacted Files Coverage Δ
flytekit/core/interface.py 79.42% <83.33%> (+0.35%) ⬆️
flytekit/core/type_engine.py 85.99% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9fab4...21190b6. Read the comment docs.

@wild-endeavor wild-endeavor merged commit 5575433 into flyteorg:master Jul 1, 2021
@fediazgon fediazgon deleted the flytekit-1116 branch July 2, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants