EnumType support in flytekit #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example usage: ```python from enum import Enum class Color(Enum): RED = "red" BLUE = "blue" GREEN = "green" @task def foo(c: Color) -> str: return c.value ``` UI/UX: Drop down. RED will be the default value flytectl: enforce the value to be limited to one of the enum values Signed-off-by: Ketan Umare <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
==========================================
+ Coverage 85.28% 85.32% +0.03%
==========================================
Files 369 369
Lines 28002 28077 +75
Branches 2270 2273 +3
==========================================
+ Hits 23882 23957 +75
Misses 3501 3501
Partials 619 619
Continue to review full report at Codecov.
|
cosmicBboy
previously approved these changes
Jun 8, 2021
| Walk the inheritance hierarchy of v and find a transformer that matches the first base class. | ||
| This is potentially non-deterministic - will depend on the registration pattern. | ||
|
|
||
| TODO lets make this deterministic by using an ordered dict |
There was a problem hiding this comment.
aren't python 3.6+ dicts ordered?
There was a problem hiding this comment.
ohh really? let me check on that
There was a problem hiding this comment.
@cosmicBboy you are right, they are insertion order preserving as explained here, but not to be confused with ordered dicts. For our usecase we want OrderedDicts right? Insertion order depends on module load order, which can be arbitrary
wild-endeavor
previously approved these changes
Jun 9, 2021
wild-endeavor
approved these changes
Jun 15, 2021
EngHabu
pushed a commit
that referenced
this pull request
Jun 24, 2021
Example usage: ```python from enum import Enum class Color(Enum): RED = "red" BLUE = "blue" GREEN = "green" @task def foo(c: Color) -> str: return c.value ``` UI/UX: Drop down. RED will be the default value flytectl: enforce the value to be limited to one of the enum values Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
pushed a commit
that referenced
this pull request
Jun 24, 2021
Example usage: ```python from enum import Enum class Color(Enum): RED = "red" BLUE = "blue" GREEN = "green" @task def foo(c: Color) -> str: return c.value ``` UI/UX: Drop down. RED will be the default value flytectl: enforce the value to be limited to one of the enum values Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
pushed a commit
that referenced
this pull request
Jun 25, 2021
Example usage: ```python from enum import Enum class Color(Enum): RED = "red" BLUE = "blue" GREEN = "green" @task def foo(c: Color) -> str: return c.value ``` UI/UX: Drop down. RED will be the default value flytectl: enforce the value to be limited to one of the enum values Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]>
wild-endeavor
pushed a commit
that referenced
this pull request
Jun 30, 2021
Example usage: ```python from enum import Enum class Color(Enum): RED = "red" BLUE = "blue" GREEN = "green" @task def foo(c: Color) -> str: return c.value ``` UI/UX: Drop down. RED will be the default value flytectl: enforce the value to be limited to one of the enum values Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: wild-endeavor <[email protected]>
wild-endeavor
pushed a commit
that referenced
this pull request
Jun 30, 2021
Example usage: ```python from enum import Enum class Color(Enum): RED = "red" BLUE = "blue" GREEN = "green" @task def foo(c: Color) -> str: return c.value ``` UI/UX: Drop down. RED will be the default value flytectl: enforce the value to be limited to one of the enum values Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: wild-endeavor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR introduces Enum Types in flytekit (flyteidl will natively support it)
Example usage:
UI/UX: Drop down. RED will be the default value
flytectl: enforce the value to be limited to one of the enum values
Signed-off-by: Ketan Umare [email protected]
Type
Are all requirements met?
Complete description
Design Doc
Tracking Issue
flyteorg/flyte#590