Fix 0.0 value floats #452
Merged
Fix 0.0 value floats #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wild-endeavor <[email protected]>
wild-endeavor
requested review from
honnix,
katrogan and
kumare3
as code owners
cosmicBboy
approved these changes
Apr 26, 2021
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
==========================================
+ Coverage 84.39% 84.40% +0.01%
==========================================
Files 344 344
Lines 25835 25841 +6
Branches 2114 2114
==========================================
+ Hits 21804 21812 +8
+ Misses 3458 3457 -1
+ Partials 573 572 -1
Continue to review full report at Codecov.
|
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
Apr 29, 2021
Signed-off-by: wild-endeavor <[email protected]> Signed-off-by: Max Hoffman <[email protected]>
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
Apr 29, 2021
Signed-off-by: wild-endeavor <[email protected]> Signed-off-by: Max Hoffman <[email protected]>
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
Apr 29, 2021
Signed-off-by: wild-endeavor <[email protected]> Signed-off-by: Max Hoffman <[email protected]>
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
May 11, 2021
Signed-off-by: wild-endeavor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wild-endeavor [email protected]
TL;DR
Converting a float of 0 fails currently.
Type
Are all requirements met?
Complete description
Using None check.
Tracking Issue
https://flyte-org.slack.com/archives/CREL4QVAQ/p1619449414338000