Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a missing test for != ne condition #443

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Added a missing test for != ne condition #443

merged 2 commits into from
Apr 7, 2021

Conversation

kumare3
Copy link
Contributor

@kumare3 kumare3 commented Apr 6, 2021

Signed-off-by: Ketan Umare [email protected]

TL;DR

Adds additional unit test, that checks for != condition

Type

  • Test only

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #443 (53ac74c) into master (03be6b0) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
+ Coverage   84.19%   84.28%   +0.08%     
==========================================
  Files         338      338              
  Lines       25448    25551     +103     
  Branches     2089     2095       +6     
==========================================
+ Hits        21426    21535     +109     
+ Misses       3449     3447       -2     
+ Partials      573      569       -4     
Impacted Files Coverage Δ
tests/flytekit/unit/core/test_type_hints.py 95.66% <100.00%> (+0.11%) ⬆️
flytekit/common/tasks/task.py 62.50% <0.00%> (-0.40%) ⬇️
tests/flytekit/unit/core/test_flyte_file.py 97.22% <0.00%> (-0.38%) ⬇️
tests/flytekit/unit/core/test_flyte_directory.py 95.65% <0.00%> (-0.27%) ⬇️
flytekit/clis/flyte_cli/main.py 43.61% <0.00%> (-0.18%) ⬇️
flytekit/core/task.py 87.80% <0.00%> (ø)
flytekit/sdk/tasks.py 75.75% <0.00%> (ø)
flytekit/clients/raw.py 64.56% <0.00%> (ø)
flytekit/models/task.py 92.85% <0.00%> (ø)
... and 136 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03be6b0...53ac74c. Read the comment docs.

@kumare3 kumare3 merged commit c56eb26 into master Apr 7, 2021
max-hoffman pushed a commit to dolthub/flytekit that referenced this pull request Apr 29, 2021
* Added a missing test for != `ne` condition

Signed-off-by: Ketan Umare <[email protected]>

* improved the test to use previous task output

Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Max Hoffman <[email protected]>
max-hoffman pushed a commit to dolthub/flytekit that referenced this pull request May 11, 2021
* Added a missing test for != `ne` condition

Signed-off-by: Ketan Umare <[email protected]>

* improved the test to use previous task output

Signed-off-by: Ketan Umare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants