update flytekit docs theme, fix index links #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cosmicBboy <[email protected]>
cosmicBboy
requested review from
honnix,
katrogan,
kumare3 and
wild-endeavor
as code owners
|
Looks good to me, how about - https://flytectl.readthedocs.io/en/latest/ |
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
==========================================
+ Coverage 84.25% 84.26% +0.01%
==========================================
Files 338 338
Lines 25528 25533 +5
Branches 2095 2095
==========================================
+ Hits 21509 21516 +7
+ Misses 3449 3448 -1
+ Partials 570 569 -1
Continue to review full report at Codecov.
|
kumare3
previously approved these changes
Mar 29, 2021
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
| @@ -1,9 +0,0 @@ | |||
| .. currentmodule:: flytekit | |||
There was a problem hiding this comment.
this is okay? the classes are still run somewhere?
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
kumare3
approved these changes
Mar 30, 2021
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
Apr 29, 2021
* update flytekit docs theme, fix index links Signed-off-by: cosmicBboy <[email protected]> * add readthedocs sphinx search Signed-off-by: cosmicBboy <[email protected]> * update flyteidl link Signed-off-by: cosmicBboy <[email protected]> * update overview and homepage Signed-off-by: cosmicBboy <[email protected]> * address comments @wild-endeavor Signed-off-by: cosmicBboy <[email protected]> * update ipykernel Signed-off-by: cosmicBboy <[email protected]> * add community link Signed-off-by: cosmicBboy <[email protected]> Signed-off-by: Max Hoffman <[email protected]>
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
May 11, 2021
* update flytekit docs theme, fix index links Signed-off-by: cosmicBboy <[email protected]> * add readthedocs sphinx search Signed-off-by: cosmicBboy <[email protected]> * update flyteidl link Signed-off-by: cosmicBboy <[email protected]> * update overview and homepage Signed-off-by: cosmicBboy <[email protected]> * address comments @wild-endeavor Signed-off-by: cosmicBboy <[email protected]> * update ipykernel Signed-off-by: cosmicBboy <[email protected]> * add community link Signed-off-by: cosmicBboy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cosmicBboy [email protected]
TL;DR
Please replace this text with a description of what this PR accomplishes.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/