add requests and limits parameter to ContainerTask #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Toledo <[email protected]>
migueltol22
requested review from
honnix,
katrogan,
kumare3 and
wild-endeavor
as code owners
Signed-off-by: Miguel Toledo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
==========================================
+ Coverage 84.25% 84.26% +0.01%
==========================================
Files 338 338
Lines 25528 25533 +5
Branches 2095 2095
==========================================
+ Hits 21509 21516 +7
+ Misses 3449 3448 -1
+ Partials 570 569 -1
Continue to review full report at Codecov.
|
kumare3
reviewed
Mar 29, 2021
| @@ -92,6 +92,7 @@ def t1(a: int) -> (int, str): | |||
| output_data_dir="/tmp", | |||
| command=["cat"], | |||
| arguments=["/tmp/a"], | |||
| requests=Resources(mem="400Mi", cpu="1"), | |||
There was a problem hiding this comment.
lets add an example without the resources specified. (I know you have the defaulting behavior, but just a gate)
|
LGTM, one comment. and please sign the DCO |
Signed-off-by: Miguel Toledo <[email protected]>
kumare3
previously approved these changes
Mar 29, 2021
migueltol22
force-pushed
the
mtoledo/containerTask-resources
branch
2 times, most recently
from
0d73743 to
7dcc1b9
Compare
kumare3
approved these changes
Mar 29, 2021
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
Apr 29, 2021
* add requests and limits parameter Signed-off-by: Miguel Toledo <[email protected]> * fix typo Signed-off-by: Miguel Toledo <[email protected]> * signoff Signed-off-by: Miguel Toledo <[email protected]> Signed-off-by: Max Hoffman <[email protected]>
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
May 11, 2021
* add requests and limits parameter Signed-off-by: Miguel Toledo <[email protected]> * fix typo Signed-off-by: Miguel Toledo <[email protected]> * signoff Signed-off-by: Miguel Toledo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This allows a user to be able to set Resources limits and requests for containerTasks.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#877
Follow-up issue
NA