Fast register for dynamic tasks #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
katrogan
requested review from
honnix,
kumare3 and
wild-endeavor
as code owners
Signed-off-by: Katrina Rogan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
==========================================
+ Coverage 84.25% 84.27% +0.01%
==========================================
Files 338 338
Lines 25528 25577 +49
Branches 2095 2104 +9
==========================================
+ Hits 21509 21555 +46
- Misses 3449 3451 +2
- Partials 570 571 +1
Continue to review full report at Codecov.
|
Signed-off-by: Katrina Rogan <[email protected]>
| with ctx.new_execution_context( | ||
| mode=ExecutionState.Mode.TASK_EXECUTION, | ||
| additional_context={ | ||
| "dynamic_addl_distro": "s3::/my-s3-bucket/fast/123", |
There was a problem hiding this comment.
Suggested change
| "dynamic_addl_distro": "s3::/my-s3-bucket/fast/123", | |
| "dynamic_addl_distro": "s3://my-s3-bucket/fast/123", |
| "distribution could be retrieved" | ||
| ) | ||
| logger.warn(f"ctx.execution_state.additional_context {ctx.execution_state.additional_context}") | ||
| sanitized_tasks = set() |
There was a problem hiding this comment.
isn't tasks already a set? why do we need another set?
wild-endeavor
approved these changes
Apr 13, 2021
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
Apr 29, 2021
Signed-off-by: Max Hoffman <[email protected]>
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Are all requirements met?
Complete description
Passes in fast register arguments and substitutes them at dynamic task compilation time.
Tracking Issue
flyteorg/flyte#824
Follow-up issue
NA