Spark2 CI #435
Merged
Spark2 CI #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honnix
requested review from
katrogan,
kumare3 and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
=======================================
Coverage 84.18% 84.18%
=======================================
Files 338 338
Lines 25486 25486
Branches 2093 2093
=======================================
Hits 21455 21455
Misses 3458 3458
Partials 573 573 Continue to review full report at Codecov.
|
|
@wild-endeavor PTAL, thanks. |
wild-endeavor
previously approved these changes
Mar 26, 2021
Signed-off-by: Hongxin Liang <[email protected]>
Signed-off-by: Hongxin Liang <[email protected]>
|
Sorry I rebased from main branch and need a new approval. @wild-endeavor |
wild-endeavor
approved these changes
Mar 26, 2021
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
Apr 29, 2021
* CI for spark2 Signed-off-by: Hongxin Liang <[email protected]> * Simplify Makefile Signed-off-by: Hongxin Liang <[email protected]> Signed-off-by: Max Hoffman <[email protected]>
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
May 11, 2021
* CI for spark2 Signed-off-by: Hongxin Liang <[email protected]> * Simplify Makefile Signed-off-by: Hongxin Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
alll-spark3is the same asallfor some time, so we are not testing spark2 in CI. This PR adds it.Type
Are all requirements met?
Complete description
Remove
all-spark3and testall-spark2.4.Tracking Issue
NA
Follow-up issue
NA