Fix map tasks #429
Merged
Fix map tasks #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katrina Rogan <[email protected]>
katrogan
requested review from
honnix,
kumare3 and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
=======================================
Coverage 84.19% 84.19%
=======================================
Files 338 338
Lines 25448 25448
Branches 2089 2089
=======================================
Hits 21426 21426
Misses 3449 3449
Partials 573 573 Continue to review full report at Codecov.
|
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
wild-endeavor
previously approved these changes
Mar 24, 2021
wild-endeavor
approved these changes
Mar 24, 2021
katrogan
pushed a commit
that referenced
this pull request
Mar 25, 2021
Signed-off-by: Katrina Rogan <[email protected]>
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Katrina Rogan [email protected]
TL;DR
Remove unused arguments breaking map task execution.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#861
Follow-up issue
NA