-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new control plane classes #425
Conversation
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
==========================================
- Coverage 84.39% 84.35% -0.05%
==========================================
Files 344 357 +13
Lines 25835 26608 +773
Branches 2114 2205 +91
==========================================
+ Hits 21804 22445 +641
- Misses 3458 3564 +106
- Partials 573 599 +26
Continue to review full report at Codecov.
|
4dd3950
to
77f2d9d
Compare
e5e317c
to
923b1d1
Compare
f632525
to
d5dd70d
Compare
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
d5dd70d
to
6686ca6
Compare
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
flytekit/control_plane/nodes.py
Outdated
self._executable_flyte_object = flyte_task or flyte_workflow or flyte_launch_plan | ||
if parameter_mapping: | ||
if not flyte_branch: | ||
self._outputs = OutputParameterMapper(self._executable_flyte_object.interface.outputs, self) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove this for now? this is old stuff.
return False | ||
|
||
@property | ||
def auth_role(self) -> _common_models.AuthRole: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this function necessary if we're just reading from the template?
Signed-off-by: cosmicBboy <[email protected]>
If you just do
you just get a funny error. I ended up having to call:
I think we need a better way to specify settings. We should probably start by respecting |
Also, just the fact that I can get network setting related errors when calling |
agreed, shall I make an issue for that? also, let me know if this is good to merge |
* implement new control plane classes Signed-off-by: cosmicBboy <[email protected]> * revert dep changes Signed-off-by: cosmicBboy <[email protected]> * remove unneeded mock integration test files Signed-off-by: cosmicBboy <[email protected]> * remove pytest.ini Signed-off-by: cosmicBboy <[email protected]> * add integration tests to ci, update reqs Signed-off-by: cosmicBboy <[email protected]> * add unit tests Signed-off-by: cosmicBboy <[email protected]> * lint Signed-off-by: cosmicBboy <[email protected]> * address comments @wild-endeavor Signed-off-by: cosmicBboy <[email protected]> Signed-off-by: Max Hoffman <[email protected]>
* implement new control plane classes Signed-off-by: cosmicBboy <[email protected]> * revert dep changes Signed-off-by: cosmicBboy <[email protected]> * remove unneeded mock integration test files Signed-off-by: cosmicBboy <[email protected]> * remove pytest.ini Signed-off-by: cosmicBboy <[email protected]> * add integration tests to ci, update reqs Signed-off-by: cosmicBboy <[email protected]> * add unit tests Signed-off-by: cosmicBboy <[email protected]> * lint Signed-off-by: cosmicBboy <[email protected]> * address comments @wild-endeavor Signed-off-by: cosmicBboy <[email protected]> Signed-off-by: Max Hoffman <[email protected]>
* implement new control plane classes Signed-off-by: cosmicBboy <[email protected]> * revert dep changes Signed-off-by: cosmicBboy <[email protected]> * remove unneeded mock integration test files Signed-off-by: cosmicBboy <[email protected]> * remove pytest.ini Signed-off-by: cosmicBboy <[email protected]> * add integration tests to ci, update reqs Signed-off-by: cosmicBboy <[email protected]> * add unit tests Signed-off-by: cosmicBboy <[email protected]> * lint Signed-off-by: cosmicBboy <[email protected]> * address comments @wild-endeavor Signed-off-by: cosmicBboy <[email protected]> Signed-off-by: Max Hoffman <[email protected]>
* implement new control plane classes Signed-off-by: cosmicBboy <[email protected]> * revert dep changes Signed-off-by: cosmicBboy <[email protected]> * remove unneeded mock integration test files Signed-off-by: cosmicBboy <[email protected]> * remove pytest.ini Signed-off-by: cosmicBboy <[email protected]> * add integration tests to ci, update reqs Signed-off-by: cosmicBboy <[email protected]> * add unit tests Signed-off-by: cosmicBboy <[email protected]> * lint Signed-off-by: cosmicBboy <[email protected]> * address comments @wild-endeavor Signed-off-by: cosmicBboy <[email protected]> Signed-off-by: Max Hoffman <[email protected]>
* implement new control plane classes Signed-off-by: cosmicBboy <[email protected]> * revert dep changes Signed-off-by: cosmicBboy <[email protected]> * remove unneeded mock integration test files Signed-off-by: cosmicBboy <[email protected]> * remove pytest.ini Signed-off-by: cosmicBboy <[email protected]> * add integration tests to ci, update reqs Signed-off-by: cosmicBboy <[email protected]> * add unit tests Signed-off-by: cosmicBboy <[email protected]> * lint Signed-off-by: cosmicBboy <[email protected]> * address comments @wild-endeavor Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy [email protected]
TL;DR
Add
Flyte*
control plane objects to give programmatic access to flyte backend data structures.Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#823
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/