Dynamically update lib version and publish all plugins #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EngHabu
requested review from
kumare3,
matthewphsmith and
wild-endeavor
as code owners
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
=======================================
Coverage 96.00% 96.00%
=======================================
Files 2 2
Lines 75 75
Branches 8 8
=======================================
Hits 72 72
Misses 1 1
Partials 2 2 Continue to review full report at Codecov.
|
katrogan
reviewed
Feb 5, 2021
| - name: Set up Python | ||
| uses: actions/setup-python@v1 | ||
| with: | ||
| python-version: "3.x" |
There was a problem hiding this comment.
do we ever have to worry about this becoming 3.9 given that numpy has incompatibilities with it?
There was a problem hiding this comment.
A fair concern... @wild-endeavor (since I copied this block)
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
May 11, 2021
Automatically publishes to pypi when a release is created. Removes the need to update any versions embedded in the files (init and setup.py) for the core library as well as plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Automatically publishes to pypi when a release is created. Removes the need to update any versions embedded in the files (init and setup.py) for the core library as well as plugins.
Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#688