Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set map task metadata only for subnode #2979

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

pvditt
Copy link
Contributor

@pvditt pvditt commented Dec 5, 2024

Tracking issue

fixes: https://linear.app/unionai/issue/COR-2212/[bug]-setting-task-metadata-for-the-parent-array-node-causes-incorrect

Why are the changes needed?

Right now metadata such as task timeout is set on the ArrayNode instead of just the subnode. This causes issues as we add support for sub node timeouts as the timeout that is intended for the subnode is also applied to the parent node.

What changes were proposed in this pull request?

Set metadata only for the subnode

How was this patch tested?

  • added unit test

Setup process

@task(timeout=timedelta(seconds=30))
def do_thing(t: int) -> str:
    sleep(15)
    return str(t)


@workflow
def wf():
    map_task(do_thing, concurrency=1)(t=[1, 2, 3])

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

flyteorg/flyte#6054

Docs link

Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Paul Dittamo <[email protected]>
@pvditt pvditt merged commit 5323fc4 into master Dec 5, 2024
104 of 105 checks passed
eapolinario pushed a commit that referenced this pull request Dec 9, 2024
* set metadata for subnode only

Signed-off-by: Paul Dittamo <[email protected]>

* update unit test

Signed-off-by: Paul Dittamo <[email protected]>

---------

Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario pushed a commit that referenced this pull request Dec 9, 2024
* set metadata for subnode only

Signed-off-by: Paul Dittamo <[email protected]>

* update unit test

Signed-off-by: Paul Dittamo <[email protected]>

---------

Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario added a commit that referenced this pull request Dec 9, 2024
* Set map task metadata only for subnode (#2979)

* set metadata for subnode only

Signed-off-by: Paul Dittamo <[email protected]>

* update unit test

Signed-off-by: Paul Dittamo <[email protected]>

---------

Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>

* Set map task metadata only for subnode (#2979)

* set metadata for subnode only

Signed-off-by: Paul Dittamo <[email protected]>

* update unit test

Signed-off-by: Paul Dittamo <[email protected]>

---------

Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>

---------

Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Paul Dittamo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants