Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pytest skip condition for delete_on_close to Python 3.12 #2939

Conversation

davidlin20dev
Copy link
Contributor

Why are the changes needed?

While developing another feature using Python 3.11.5, I ran make test, which resulted in the following error:

Screenshot 2024-11-18 at 19 29 47

According to the Python Docs, the delete_on_close parameter was introduced in version 3.12.

What changes were proposed in this pull request?

Originally:

@pytest.mark.skipif(
    sys.version_info < (3, 10), reason="handling for windows is nicer with delete_on_close, which doesn't exist in 3.9"
)

After changes:

@pytest.mark.skipif(
    sys.version_info < (3, 12), reason="handling for windows is nicer with delete_on_close, which doesn't exist before 3.12"
)

This change ensures compatibility by updating the condition to skip tests for Python versions earlier than 3.12, where delete_on_close is unavailable.

Setup process

Run make test

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.33%. Comparing base (39e7227) to head (6c1c179).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2939       +/-   ##
===========================================
+ Coverage   51.46%   79.33%   +27.87%     
===========================================
  Files         199      199               
  Lines       20870    20870               
  Branches     2684     2684               
===========================================
+ Hits        10740    16557     +5817     
+ Misses       9528     3565     -5963     
- Partials      602      748      +146     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Future-Outlier Future-Outlier merged commit faee3da into flyteorg:master Nov 19, 2024
106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants