Update pytest skip condition for delete_on_close to Python 3.12 #2939
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
While developing another feature using Python 3.11.5, I ran
make test
, which resulted in the following error:According to the Python Docs, the
delete_on_close
parameter was introduced in version 3.12.What changes were proposed in this pull request?
Originally:
After changes:
This change ensures compatibility by updating the condition to skip tests for Python versions earlier than 3.12, where delete_on_close is unavailable.
Setup process
Run
make test
Check all the applicable boxes