-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update array node map task to support an additional plugin #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2934 +/- ##
==========================================
- Coverage 51.25% 46.65% -4.60%
==========================================
Files 200 200
Lines 20835 20849 +14
Branches 2688 2689 +1
==========================================
- Hits 10678 9728 -950
- Misses 9559 10644 +1085
+ Partials 598 477 -121 ☔ View full report in Codecov by Sentry. |
pvditt
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
November 15, 2024 19:33
pvditt
changed the title
Update array node map task
Update array node map task to support an additional plugin
Nov 15, 2024
Signed-off-by: Paul Dittamo <[email protected]>
…ask extensions Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Paul Dittamo <[email protected]>
This reverts commit e98bc6e. Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Paul Dittamo <[email protected]>
pvditt
force-pushed
the
update-array-node-map-task
branch
from
November 21, 2024 01:21
86bfe79
to
505570a
Compare
Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
approved these changes
Dec 2, 2024
arbaobao
pushed a commit
to arbaobao/flytekit
that referenced
this pull request
Dec 4, 2024
…2934) * have get_custom return subtask and remove un-needed array job Signed-off-by: Paul Dittamo <[email protected]> * set is_original_sub_node_interface + FULL_STATE for python function task extensions Signed-off-by: Paul Dittamo <[email protected]> * lint Signed-off-by: Paul Dittamo <[email protected]> * unit test Signed-off-by: Paul Dittamo <[email protected]> * clean up Signed-off-by: Paul Dittamo <[email protected]> * idl update Signed-off-by: Paul Dittamo <[email protected]> * Revert "idl update" This reverts commit e98bc6e. Signed-off-by: Paul Dittamo <[email protected]> * pass in boolvalue Signed-off-by: Paul Dittamo <[email protected]> * update unit test Signed-off-by: Paul Dittamo <[email protected]> * Set flyteidl lower bound Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Paul Dittamo <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
closes: https://linear.app/unionai/issue/COR-2239/add-additional-dataexecution-modes-for-array-node
Why are the changes needed?
start to add support for array node map task to run additional plugins (ie actors)
need to merge flyteorg/flyte#6018 in before merging this
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link