Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw container (copilot) integration test #2891

Closed

Conversation

wayner0628
Copy link
Contributor

Tracking issue

flyteorg/flyte#5930

Why are the changes needed?

To prevent in the future, someone writing code that will break the copilot.

What changes were proposed in this pull request?

Add code tests/flytekit/unit/core/test_local_raw_container.py to tests/flytekit/integration/remote/test_remote.py.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#2887

Docs link

Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.23%. Comparing base (6bf6f8e) to head (c242784).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2891      +/-   ##
==========================================
+ Coverage   76.79%   79.23%   +2.43%     
==========================================
  Files         196      199       +3     
  Lines       20546    20792     +246     
  Branches     2646     2673      +27     
==========================================
+ Hits        15779    16474     +695     
+ Misses       4068     3573     -495     
- Partials      699      745      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wayner0628 wayner0628 closed this Nov 3, 2024
@wayner0628 wayner0628 deleted the raw_container_integration_test branch November 3, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant