-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update task.py #2791
Update task.py #2791
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Signed-off-by: RaghavMangla <[email protected]>
@kumare3 @eapolinario @pingsutw @cosmicBboy @samhita-alla @thomasjpfan @Future-Outlier can u pls review this pr |
Can you run a workflow example like this and prove to us that it works as expected? |
@Future-Outlier this is a documentation change, is a workflow required still? |
saw that my PR falied on one of the tests, any ideas on how to fix that? |
Congrats on merging your first pull request! 🎉 |
will this PR be considered for hacktoberfest? @wild-endeavor @Future-Outlier @samhita-alla |
Signed-off-by: RaghavMangla <[email protected]>
Signed-off-by: RaghavMangla <[email protected]>
Why are the changes needed?
Issue description:
the papermill example in the flyte docs lacks info on rendering the notebook in a deck.
slack thread for reference: https://discuss.flyte.org/t/15484282/hi-all-flyte-rookie-here-maybe-you-can-help-me-out-i-m-tryin#33b0b813-6822-4451-8977-eaec3387a4ff
What changes were proposed in this pull request?
to achieve this, added render_deck=True and enable_deck=True to the notebooktask.
Screenshots