Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update task.py #2791

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Update task.py #2791

merged 2 commits into from
Oct 11, 2024

Conversation

RaghavMangla
Copy link
Contributor

Why are the changes needed?

Issue description:
the papermill example in the flyte docs lacks info on rendering the notebook in a deck.

slack thread for reference: https://discuss.flyte.org/t/15484282/hi-all-flyte-rookie-here-maybe-you-can-help-me-out-i-m-tryin#33b0b813-6822-4451-8977-eaec3387a4ff

What changes were proposed in this pull request?

to achieve this, added render_deck=True and enable_deck=True to the notebooktask.

Screenshots

Copy link

welcome bot commented Oct 7, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

Signed-off-by: RaghavMangla <[email protected]>
@wild-endeavor wild-endeavor enabled auto-merge (squash) October 8, 2024 16:33
@RaghavMangla
Copy link
Contributor Author

@Future-Outlier
Copy link
Member

@kumare3 @eapolinario @pingsutw @cosmicBboy @samhita-alla @thomasjpfan @Future-Outlier can u pls review this pr

Can you run a workflow example like this and prove to us that it works as expected?
#1870

@RaghavMangla
Copy link
Contributor Author

RaghavMangla commented Oct 9, 2024 via email

@RaghavMangla
Copy link
Contributor Author

@Future-Outlier this is a documentation change, is a workflow required still?

@RaghavMangla
Copy link
Contributor Author

image
this is what i got on rendering html page for this, can u pls mention which is the new documentation for flyte docs

@RaghavMangla
Copy link
Contributor Author

saw that my PR falied on one of the tests, any ideas on how to fix that?

@wild-endeavor wild-endeavor merged commit 62ee57e into flyteorg:master Oct 11, 2024
104 checks passed
Copy link

welcome bot commented Oct 11, 2024

Congrats on merging your first pull request! 🎉

@RaghavMangla
Copy link
Contributor Author

will this PR be considered for hacktoberfest? @wild-endeavor @Future-Outlier @samhita-alla

otarabai pushed a commit to otarabai/flytekit that referenced this pull request Oct 15, 2024
kumare3 pushed a commit that referenced this pull request Nov 8, 2024
Signed-off-by: RaghavMangla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants