-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flyte Decks] support ydata-profiling in python 3.12 #2766
[Flyte Decks] support ydata-profiling in python 3.12 #2766
Conversation
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
I don't want to block this PR, but can we make all of the dependencies of this plugin "soft dependencies"? i.e. we import them lazily and complain at runtime if it's not installed. Can make this a separate PR. |
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Can we update the README to just document the additional requirements you need in order to use each renderer? |
+1, we can add a table |
Signed-off-by: Future-Outlier <[email protected]>
…bal-uv Signed-off-by: Future-Outlier <[email protected]>
Hi, @pingsutw @cosmicBboy |
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2766 +/- ##
===========================================
+ Coverage 42.96% 78.96% +35.99%
===========================================
Files 215 194 -21
Lines 20685 19807 -878
Branches 3905 4130 +225
===========================================
+ Hits 8887 15640 +6753
+ Misses 11683 3447 -8236
- Partials 115 720 +605
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thank you
Hey @Future-Outlier A minimal installation of the plugin seems to be broken now. Do you think |
+1 to the above! |
Fixing, thank you |
* [Flyte Decks] support ydata-profiling in python 3.12 Signed-off-by: Future-Outlier <[email protected]> * remove exclude deck standard python3.12 ci Signed-off-by: Future-Outlier <[email protected]> * make plugin soft dependencies Signed-off-by: Future-Outlier <[email protected]> * add dev-requirements.in Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * better README with dependenc Signed-off-by: Future-Outlier <[email protected]> * add other dependency in dev-requirements.in, this will help setup-global-uv Signed-off-by: Future-Outlier <[email protected]> * Trigger CI Signed-off-by: Future-Outlier <[email protected]> * Trigger CI Signed-off-by: Future-Outlier <[email protected]> * Update dependenct Signed-off-by: Future-Outlier <[email protected]> * new dockerfile dev Signed-off-by: Future-Outlier <[email protected]> * new dockerfile Signed-off-by: Future-Outlier <[email protected]> * new dockerfile Signed-off-by: Future-Outlier <[email protected]> * revert back Signed-off-by: Future-Outlier <[email protected]> * new dev image Signed-off-by: Future-Outlier <[email protected]> --------- Signed-off-by: Future-Outlier <[email protected]>
* [Flyte Decks] support ydata-profiling in python 3.12 Signed-off-by: Future-Outlier <[email protected]> * remove exclude deck standard python3.12 ci Signed-off-by: Future-Outlier <[email protected]> * make plugin soft dependencies Signed-off-by: Future-Outlier <[email protected]> * add dev-requirements.in Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * better README with dependenc Signed-off-by: Future-Outlier <[email protected]> * add other dependency in dev-requirements.in, this will help setup-global-uv Signed-off-by: Future-Outlier <[email protected]> * Trigger CI Signed-off-by: Future-Outlier <[email protected]> * Trigger CI Signed-off-by: Future-Outlier <[email protected]> * Update dependenct Signed-off-by: Future-Outlier <[email protected]> * new dockerfile dev Signed-off-by: Future-Outlier <[email protected]> * new dockerfile Signed-off-by: Future-Outlier <[email protected]> * new dockerfile Signed-off-by: Future-Outlier <[email protected]> * revert back Signed-off-by: Future-Outlier <[email protected]> * new dev image Signed-off-by: Future-Outlier <[email protected]> --------- Signed-off-by: Future-Outlier <[email protected]>
Why are the changes needed?
(We need
PIL
module for image renderer)What changes were proposed in this pull request?
flytekit-deck-standard
,ydata-profiling
andpillow
.exclude flytekit-deck-standard in python 3.12 CI
How was this patch tested?
local execution and remote execution
Screenshots
Check all the applicable boxes