-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pythonpath "." before loading modules #2673
Merged
+7
−3
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8e21f18
add pythonpath . before loading modules
arbaobao fe4ac21
Merge branch 'flyteorg:master' into add_pythonpath
arbaobao 865d065
fix make lint failed
arbaobao 9e7956b
Merge branch 'flyteorg:master' into add_pythonpath
arbaobao 3cb410d
Merge branch 'add_pythonpath' of github.com:arbaobao/flytekit into ad…
arbaobao 2f0d01d
improve code and remove pythonpath in Dockerfile.dev
arbaobao 855d6cc
Merge branch 'master' into add_pythonpath
arbaobao de9d1df
add pythonpath '.' if '.' isn't in sys.path
arbaobao 710d143
Merge branch 'add_pythonpath' of github.com:arbaobao/flytekit into ad…
arbaobao 8902707
remove test
arbaobao 659515c
change adding working_dir to dynamic_dest_dir
arbaobao 30dd9ba
Merge branch 'flyteorg:master' into add_pythonpath
arbaobao c3c4bab
rollback changes back to previous
arbaobao 3538338
Merge branch 'add_pythonpath' of github.com:arbaobao/flytekit into ad…
arbaobao 152d033
lint
arbaobao 4afb6ae
add working_dir in map task
arbaobao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing this broke flyteremote integration tests due to the way tasks+workflows are registered. The tests end up present in the image under the
tests
module, which lives under theflytekit
directory and since we had/flytekit
as part ofPYTHONPATH
the task was able to be run oncepyflyte-execute
ran.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix in #2701.