Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call remote when --help in remote-X #2642

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Don't call remote when --help in remote-X #2642

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed193e5
don't call remote
wild-endeavor Aug 2, 2024
7c823fa
nit
wild-endeavor Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions flytekit/clis/sdk_in_container/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import json
import os
import pathlib
import sys
import tempfile
import typing
from dataclasses import dataclass, field, fields
Expand Down Expand Up @@ -741,6 +742,8 @@ def _get_entities(self, r: FlyteRemote, project: str, domain: str, limit: int) -
return []

def list_commands(self, ctx):
if "--help" in sys.argv:
return []
if self._entities or ctx.obj is None:
return self._entities

Expand Down
Loading