Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kubernetes package to official docker image again #2589

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

flixr
Copy link
Contributor

@flixr flixr commented Jul 19, 2024

as it is needed in order to use pod templates.
This was indirectly removed with #2455

Why are the changes needed?

needed to use pod templates with the official image

What changes were proposed in this pull request?

install kubernetes package in image

as it is needed in order to use pod templates.
This was indirectly removed with flyteorg#2455

Signed-off-by: Felix Ruess <[email protected]>
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay.

kubernetes dependencies overlaps with many of our other indirect dependencies, so it does not include the image size too much.

@pingsutw pingsutw merged commit 551924a into flyteorg:master Jul 19, 2024
46 of 47 checks passed
@flixr flixr deleted the docker_image_kubernetes branch July 20, 2024 07:41
mao3267 pushed a commit to mao3267/flytekit that referenced this pull request Jul 29, 2024
as it is needed in order to use pod templates.
This was indirectly removed with flyteorg#2455

Signed-off-by: Felix Ruess <[email protected]>
Signed-off-by: mao3267 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants