Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dataclasses json dependency from flytekit #2557

Conversation

Future-Outlier
Copy link
Member

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier Future-Outlier changed the title Removefrom json and to json in the Dataclass transformer Remove from json and to json in the Dataclass transformer Jul 3, 2024
@Future-Outlier
Copy link
Member Author

TODO:
I have to use these code to support JsonParamType in click_types.py.

decoder = JSONDecoder(self._python_type)
return decoder.decode(json.dumps(parsed_value))

@Future-Outlier Future-Outlier requested a review from fg91 as a code owner July 6, 2024 04:11
Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier Future-Outlier changed the title Remove from json and to json in the Dataclass transformer Remove dataclasses json dependency from flytekit Jul 6, 2024
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 94.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.02%. Comparing base (a6a8651) to head (be9602e).
Report is 9 commits behind head on master.

Files Patch % Lines
flytekit/core/type_engine.py 94.11% 1 Missing ⚠️
flytekit/extras/pytorch/checkpoint.py 0.00% 1 Missing ⚠️
flytekit/extras/tensorflow/record.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2557      +/-   ##
==========================================
- Coverage   76.27%   75.02%   -1.25%     
==========================================
  Files         183      254      +71     
  Lines       18716    21726    +3010     
  Branches     3694     3689       -5     
==========================================
+ Hits        14275    16301    +2026     
- Misses       3804     4772     +968     
- Partials      637      653      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Future-Outlier <[email protected]>
@Future-Outlier
Copy link
Member Author

TODO:
Check test_guess_dict4's behavior by debugger to know why we can't construct dataclass correctly by convert_mashumaro_json_schema_to_python_class.

@Future-Outlier Future-Outlier marked this pull request as draft July 6, 2024 06:04
@guyarad
Copy link

guyarad commented Aug 13, 2024

@Future-Outlier thanks for this PR! We would really like it if it could be completed soon.
Is there anything we can do to expedite it? is anything broken with this code?
All tests are passing... so why is it still a draft?

@Future-Outlier
Copy link
Member Author

@Future-Outlier thanks for this PR! We would really like it if it could be completed soon.

Is there anything we can do to expedite it? is anything broken with this code?

All tests are passing... so why is it still a draft?

I am in the military service, will come back in the next two weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants