-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dataclasses json
dependency from flytekit
#2557
Remove dataclasses json
dependency from flytekit
#2557
Conversation
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
from json
and to json
in the Dataclass transformerfrom json
and to json
in the Dataclass transformer
TODO: decoder = JSONDecoder(self._python_type)
return decoder.decode(json.dumps(parsed_value)) |
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
from json
and to json
in the Dataclass transformerdataclasses json
dependency from flytekit
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2557 +/- ##
==========================================
- Coverage 76.27% 75.02% -1.25%
==========================================
Files 183 254 +71
Lines 18716 21726 +3010
Branches 3694 3689 -5
==========================================
+ Hits 14275 16301 +2026
- Misses 3804 4772 +968
- Partials 637 653 +16 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
TODO: |
@Future-Outlier thanks for this PR! We would really like it if it could be completed soon. |
I am in the military service, will come back in the next two weeks |
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link