Annotations branch fix #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EngHabu
requested review from
matthewphsmith and
wild-endeavor
as code owners
kumare3
reviewed
Nov 19, 2020
kumare3
reviewed
Nov 19, 2020
| @@ -292,7 +304,7 @@ def transform_to_conj_expr(expr: ConjunctionExpression) -> (_core_cond.Conjuncti | |||
|
|
|||
| def transform_to_operand(v: Union[Promise, Literal]) -> (_core_cond.Operand, Optional[Promise]): | |||
| if isinstance(v, Promise): | |||
| return _core_cond.Operand(var=v.var), v | |||
| return _core_cond.Operand(var=create_branch_node_promise_var(v.ref.node_id, v.var)), v | |||
There was a problem hiding this comment.
so indeed this was the only change needed on flytekit side?
|
lgtm |
kumare3
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Ensure that inputs variables to a branch node have unique names instead of copying the name from the promise as is.
Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#602