Cleanup flytekit dependencies that bloat the package and are not used #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Flytekit has plugins for tensorflow and pytorch, but it does not really depend on pytorch or tensorflow - Users should install their own versions of tensorflow and pytorch
kumare3
requested review from
matthewphsmith and
wild-endeavor
as code owners
wild-endeavor
previously approved these changes
Oct 21, 2020
kumare3
changed the title
wild-endeavor
approved these changes
Oct 21, 2020
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
May 11, 2021
…flyteorg#216) * Cleanup flytekit installations - Flytekit has plugins for tensorflow and pytorch, but it does not really depend on pytorch or tensorflow - Users should install their own versions of tensorflow and pytorch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
really depend on pytorch or tensorflow
Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#564
Follow-up issue
NA