MAINT Remove wrapt dependency #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas J. Fan <[email protected]>
Signed-off-by: Thomas J. Fan <[email protected]>
thomasjpfan
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1973 +/- ##
==========================================
+ Coverage 85.22% 85.81% +0.59%
==========================================
Files 287 313 +26
Lines 22072 23299 +1227
Branches 3528 3530 +2
==========================================
+ Hits 18810 19995 +1185
- Misses 2659 2701 +42
Partials 603 603 ☔ View full report in Codecov by Sentry. |
pingsutw
previously approved these changes
Nov 17, 2023
Signed-off-by: Thomas J. Fan <[email protected]>
cosmicBboy
approved these changes
Nov 22, 2023
pingsutw
approved these changes
Nov 22, 2023
ringohoffman
pushed a commit
to ringohoffman/flytekit
that referenced
this pull request
Nov 24, 2023
* MAINT Remove wrapt dependency Signed-off-by: Thomas J. Fan <[email protected]> * MAINT Removes wrapt dependency from requirements Signed-off-by: Thomas J. Fan <[email protected]> --------- Signed-off-by: Thomas J. Fan <[email protected]>
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
* MAINT Remove wrapt dependency Signed-off-by: Thomas J. Fan <[email protected]> * MAINT Removes wrapt dependency from requirements Signed-off-by: Thomas J. Fan <[email protected]> --------- Signed-off-by: Thomas J. Fan <[email protected]> Signed-off-by: Rafael Raposo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes wrapt as a direct dependency.
Type
Are all requirements met?
Complete description
This PR removes the wrapt dependency by rewriting wrapt's
_decoratorusing functools.wrap.Tracking Issue
Towards flyteorg/flyte#4418