MAINT Removes sortedcontainers, deprecated, and dateutil dependencies #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas J. Fan <[email protected]>
thomasjpfan
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
|
We might need to fast-track the idea of providing storage extras (one for gcsfs, azure, etc). |
…endencies Signed-off-by: Thomas J. Fan <[email protected]>
…endencies Signed-off-by: Thomas J. Fan <[email protected]>
Signed-off-by: Thomas J. Fan <[email protected]>
thomasjpfan
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1970 +/- ##
=======================================
Coverage 62.54% 62.54%
=======================================
Files 313 313
Lines 23249 23249
Branches 3526 3526
=======================================
Hits 14540 14540
Misses 8286 8286
Partials 423 423 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Thomas J. Fan <[email protected]>
thomasjpfan
changed the title
|
Looks like |
eapolinario
approved these changes
Nov 21, 2023
ringohoffman
pushed a commit
to ringohoffman/flytekit
that referenced
this pull request
Nov 24, 2023
…flyteorg#1970) * MAINT Remove sorted-containers, deprecated, and urllib3 dependency Signed-off-by: Thomas J. Fan <[email protected]> * Add urllib to see if it fixes the dependency resolution Signed-off-by: Thomas J. Fan <[email protected]> * Remove dateutil Signed-off-by: Thomas J. Fan <[email protected]> --------- Signed-off-by: Thomas J. Fan <[email protected]>
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
…flyteorg#1970) * MAINT Remove sorted-containers, deprecated, and urllib3 dependency Signed-off-by: Thomas J. Fan <[email protected]> * Add urllib to see if it fixes the dependency resolution Signed-off-by: Thomas J. Fan <[email protected]> * Remove dateutil Signed-off-by: Thomas J. Fan <[email protected]> --------- Signed-off-by: Thomas J. Fan <[email protected]> Signed-off-by: Rafael Raposo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the sortedcontainers, deprecated, and dateutil dependencies.
Type
Are all requirements met?
Complete description
This PR:
deprecateddependency.sortedcontainersanddateutil. Flytekit still has dependencies that depend onsortedcontainersanddateutil.Tracking Issue
Towards flyteorg/flyte#4418