Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a less strict deadline for hypothesis tests #1682

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

eapolinario
Copy link
Collaborator

TL;DR

Hypothesis tests sometimes take more than the default 200ms to run

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

For example #1678

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #1682 (c8794c8) into master (b410108) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1682      +/-   ##
==========================================
- Coverage   71.21%   71.00%   -0.21%     
==========================================
  Files         334      336       +2     
  Lines       30531    30788     +257     
  Branches     5522     5587      +65     
==========================================
+ Hits        21743    21862     +119     
- Misses       8246     8370     +124     
- Partials      542      556      +14     
Impacted Files Coverage Δ
.../flytekit/unit/core/test_type_conversion_errors.py 100.00% <100.00%> (ø)

... and 34 files with indirect coverage changes

@eapolinario eapolinario merged commit ad56f8a into master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants