Add --raw-output-data-prefix to the pyflyte-execute command #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 25, 2020 16:41
EngHabu
reviewed
Aug 26, 2020
| @@ -447,6 +447,8 @@ def _get_container_definition( | |||
| "{{.input}}", | |||
| "--output-prefix", | |||
| "{{.outputPrefix}}", | |||
| "--raw-data-output-prefix", | |||
| "{{.outputPrefix}}" | |||
There was a problem hiding this comment.
This should be raw output prefix, right?
There was a problem hiding this comment.
yeah this is when i realized that flyteplugins wasn't done
wild-endeavor
changed the title
added 2 commits
August 26, 2020 13:21
|
Hurrah! One step closer to portable Workflows. Definitely all the examples will be portable |
kumare3
reviewed
Aug 27, 2020
| @@ -83,7 +83,8 @@ def _execute_task(task_module, task_name, inputs, output_prefix, test): | |||
| _data_proxy.Data.get_data(inputs, local_inputs_file) | |||
| input_proto = _utils.load_proto_from_file(_literals_pb2.LiteralMap, local_inputs_file) | |||
| _engine_loader.get_engine().get_task(task_def).execute( | |||
| _literal_models.LiteralMap.from_flyte_idl(input_proto), context={"output_prefix": output_prefix}, | |||
| _literal_models.LiteralMap.from_flyte_idl(input_proto), | |||
There was a problem hiding this comment.
wow this seems some hairy logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Please see the linked issue for more information. This adds a
--raw-output-data-prefixswitch to the pyflyte-execute command and container args will be changed so that they're registered with--raw-data-output-prefix {{.rawOutputDataPrefix}}. Propeller will then fill them in.Release this change last, after testing propeller/plugins
Type
Are all requirements met?
Complete description
get_random_pathis called. If it is missing it will fall back to the current behavior of looking up either the S3 shard formatter config or the GCS prefix config.Tracking Issue
flyteorg/flyte#211
Follow-up issue
NA